Use a GatewayFilter to redirect to the login page when given a login query parameter #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…query parameter The geOrchestra Gateway has a requirement to redirect to /login when a request has a `login` query parameter (e.g. `/geonetwork/?login` -> `/login`), that comes from the old security proxy. So far it was implemented in `AccessRulesCustomizer` by requiring such requests to be authenticated, and delegating to spring security to perform the redirection. When the request is not authenticated already, and the request headers do not contain `Accept: text/html`, spring security would challenge with a basic auth popup instead. This patch introduces a `LoginParamRedirectGatewayFilter`, set up as one of the default filters in `application.yml`, that performs a redirect in either case, delegating to a `org.springframework.cloud.gateway.filter.factory.RedirectToGatewayFilterFactory`. Check out `docs/custom_filters.adoc` for configuration information.
groldan
added a commit
to georchestra/datadir
that referenced
this pull request
Jul 13, 2024
…query parameter Configuration required for this gateway change: georchestra/georchestra-gateway#133 This patch adds the `LoginParamRedirect` default filter to the gateway. Note the filter is added by default in the embedded `application.yml`, but since `gateway/application.yaml` is overriding the `spring.cloud.gateway.default-filters` list, it must be added here too.
edevosc2c
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Thank you @groldan.
I just deployed this PR in dev at https://geodata.dev.inrae.fr and this works great!
I'm now using the all default-filters and the ?login redirect behavior is now the same whatever the "accept" header.
For me it's good to be merged. I didn't review the code, just validated that it fixes the bug.
github-actions bot
pushed a commit
to georchestra/datadir
that referenced
this pull request
Jul 26, 2024
…query parameter Configuration required for this gateway change: georchestra/georchestra-gateway#133 This patch adds the `LoginParamRedirect` default filter to the gateway. Note the filter is added by default in the embedded `application.yml`, but since `gateway/application.yaml` is overriding the `spring.cloud.gateway.default-filters` list, it must be added here too. (cherry picked from commit 5ba6510)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The geOrchestra Gateway has a requirement to redirect to /login when a request has a
loginquery parameter (e.g./geonetwork/?login->/login), that comes from the old security proxy.So far it was implemented in
AccessRulesCustomizerby requiring such requests to be authenticated, and delegating to spring security to perform the redirection.When the request is not authenticated already, and the request headers do not contain
Accept: text/html, spring security would challenge with a basic auth popup instead.This patch introduces a
LoginParamRedirectGatewayFilter, set up as one of the default filters inapplication.yml, that performs a redirect in either case, delegating to aorg.springframework.cloud.gateway.filter.factory.RedirectToGatewayFilterFactory.Check out
docs/custom_filters.adocfor configuration information.Note for the docker composition, the following datadir PR is required:
georchestra/datadir#415
The rationale is in the PR description
Fixes #132