Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-175 - Change the pictogram of the cadastrapp plugin #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LPoin
Copy link
Contributor

@LPoin LPoin commented Dec 20, 2024

Modify Cadastrapp icon with new created by Agathe Adam.

@pierrejego pierrejego self-requested a review December 20, 2024 09:18
@pierrejego pierrejego self-assigned this Dec 20, 2024
@pierrejego pierrejego added this to the v2.2.2 milestone Dec 20, 2024
@LPoin LPoin changed the title ISSUE-175 - Change the pictogramm of the cadastrapp plugin ISSUE-175 - Change the pictogram of the cadastrapp plugin Dec 20, 2024
@landryb
Copy link
Member

landryb commented Dec 20, 2024

i think something is missing in the webpack config, because building the extension, the dist/Cadastrapp.zip archive doesn't contain the svg file. Maybe look at how it's handled for translations in https://github.com/georchestra/mapstore2-cadastrapp/blob/master/build/extension/prod-webpack.config.js#L13 ?

@pierrejego pierrejego marked this pull request as draft December 20, 2024 09:54
@pierrejego
Copy link
Member

Not tested in integration for the moment, only in dev

@LPoin
Copy link
Contributor Author

LPoin commented Dec 27, 2024

Tested in integration.
Mapstore 2023.02
Node 16.20.2

@pierrejego pierrejego marked this pull request as ready for review January 13, 2025 13:53
@pierrejego
Copy link
Member

When I upload new plugin in mapstore administration, extension Icon is not the good one. I think there is another link to change.

image

Conflict need to be resolved to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants