Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-multitouch v1_01 PCBs #2

Open
wants to merge 2 commits into
base: peacock
Choose a base branch
from

Conversation

irt-yv
Copy link

@irt-yv irt-yv commented Aug 29, 2024

Description

The multitouch branches are very jumpy and hard to use on MacOS. The basic peacock branch works much more smoothly for cursor, scrolling, tap and two finger tap. This PR adds support for version 1_01+ PCBs with the updated traces and working encoders.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

irt-yv added 2 commits August 29, 2024 12:40
…ouch

Add support for v1_01 peacock boards on the non-multitouch branch. This allows
the trackpads to work much more cleanly and smoothly on MacOS where multitouch
is buggy.
@george-norton
Copy link
Owner

Hello, sorry I just spotted this PR. I have been making some improvements for MacOS support, can you retry the multitouch_experiment branch.

The latest code should also add 3 finger gesture support for mouse emulation mode (Tap for middle click, Swipe up for L_GUI, swipe left/right for back/forward).

@irt-yv
Copy link
Author

irt-yv commented Sep 9, 2024

Hello, sorry I just spotted this PR. I have been making some improvements for MacOS support, can you retry the multitouch_experiment branch.

The latest code should also add 3 finger gesture support for mouse emulation mode (Tap for middle click, Swipe up for L_GUI, swipe left/right for back/forward).

Do I need to enable some flag for mouse emulation mode specifically. The branch is a lot less jittery now and usable although the scroll is very twitchy. The gestures aren't registering.

@george-norton
Copy link
Owner

Hello, sorry I just ran a test and noticed that I had broken the resolution configuration. Movement vertically was too fast, I have pushed a fix for that. I don't have a Mac, but I have forced mouse mode on Linux and I am getting gestures.

Sorry, the branch is in a bit of flux at the moment, there is another trackpad in the works and we are running a beta test, we are attempting to tune things a little better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants