[BUGFIX] Exclude domain models from DI container scanning #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domain models should not be scanned during DI Container building, since entities are not meant to be services. The actual bug that results of this missing configuration line is an exception which ocurrs when the extbase ClassSchema is built in the same request as the DI Container scanned all classes. The issue this PR targets is georgringer/eventnews#102
georgringer
approved these changes
May 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain models should not be scanned during DI Container building, since
entities are not meant to be services. The actual bug that results of
this missing configuration line is an exception which ocurrs when
the extbase ClassSchema is built in the same request as the DI Container
scanned all classes.
The issue this PR targets is georgringer/eventnews#102