-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update benchmark YAML files with new species for GEOS-Chem 14.5.0 #331
Conversation
gcpy/benchmark/modules/emission_species.yml - Added species CH2I2, CH2IBr, CH2ICl, MOH, O3, PHEN, SALAAL, SALACL, SALCAL, and SALCCL CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
Hi everyone! Could we add RCOOH and ACR to secondary organics? Could we add ALK6, C4H6, TMB, STYR, EBZ to primary organics? Could NOy include the following additions (in red?) Also @kelvinhb could we add ACR emissions to the emissions pull request? |
Katie's additions look good, I'd also add that: |
gcpy/benchmark/modules/benchmark_categories.yml gcpy/benchmark/modules/lumped_species.yml - Updated with the latest species for GEOS-Chem 14.5.0, corresponding to feedback from @ktravis213 and @kelvinhb CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
@ktravis213, @kelvinhb: I've updated the |
gcpy/benchmark/modules/emission_species.yml - Added new species from GEOS-Chem 14.5.0: ACR, C4H6, MVK, STYR, TMB Signed-off-by: Bob Yantosca <[email protected]>
@ktravis213 @kelvinhb: I also added ACR, C4H6, MVK, STYR, TMB to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge. Thanks @yantosca!
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This PR updates the following benchmark configuration files with the latest species as of GEOS-Chem 14.5.0:
This will make sure to include new species into the proper benchmark categories, etc.
Expected changes
New species will be included in the proper PDF corresponding to its category. Also units will be properly specified in emissions tables.
Reference(s)
N/A
Related Github Issue
Tagging @msulprizio @lizziel @ktravis213 @kelvinhb