Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ALK6 species name for >= C6 alkanes instead of ALK7 #2493

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

msulprizio
Copy link
Contributor

Name and Institution (Required)

Name: Melissa Sulprizio
Institution: Harvard

Describe the update

For consistency with the literature (e.g. Travis et al, EGUsphere, 2024) we rename ALK7 to ALK6. See further discussion in Github issue #2459.

Expected changes

This is a zero difference update simply changing a species name.

Reference(s)

Related Github Issue

For consistency with the literature (e.g. Travis et al, EGUsphere, 2024)
we rename ALK7 to ALK6. See further discussion in Github issue
#2459.

Signed-off-by: Melissa Sulprizio <[email protected]>
@msulprizio msulprizio added the topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms label Oct 1, 2024
@msulprizio msulprizio added this to the 14.5.0 milestone Oct 1, 2024
@msulprizio msulprizio self-assigned this Oct 1, 2024
msulprizio added a commit to geoschem/gcpy that referenced this pull request Oct 2, 2024
For consistency with the literature (e.g. Travis et al, EGUsphere, 2024)
we rename ALK7 to ALK6.

This should be merged in at the same time as geoschem/geos-chem#2493.

Signed-off-by: Melissa Sulprizio <[email protected]>
@msulprizio
Copy link
Contributor Author

All GCClassic and GCHP integration tests pass on this PR

Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a renaming of ALK7 to ALK6 in all relevant files. I have confirmed that the renaming is correct. Good to merge!

@msulprizio msulprizio merged commit 57cf0df into dev/14.5.0 Oct 3, 2024
@msulprizio msulprizio deleted the feature/rename-alk7-to-alk6 branch October 3, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: Chemical Mechanisms Related to KPP and/or GEOS-Chem chemistry mechanisms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants