Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with menu-bar; clean up geos-chem.css #6

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Apr 6, 2023

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harard + GCST

Confirm you have reviewed the following documentation

Describe the update

This PR eliminates the white space between the blue menu bar and dropdown menus, which can make navigation difficult on some browsers. The fix was to increase the top and bottom padding by 2px, making the menu bar thicker and filling the gap.

We have also removed code from geos-chem.css that was automatically added by OpenScholar.

Expected changes

  1. There is no longer a gap between the menu bar and dropdowns
  2. The menu headings have been edited so as not to run to a second line

Related Github Issue(s)

#5

css/geos-chem.css
- Increase the thickness of the menu bar to 12px padding at top &
  bottom.  This will remove the gap between the menu bar and dropdowns,
  which makes it difficult to navigate to the dropddowns on some
  browsers

dropdown-menu.js
- Remove code and styles not found in geos-chem.css

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added category: Feature Request New feature or request topic: CSS Pertaining to issues with CSS style sheets topic: Javascript Pertaining to issues with Javascript scripts topic: Dropdown Menus Pertaining to issues with dropdown menus labels Apr 6, 2023
@yantosca yantosca requested a review from msulprizio April 6, 2023 18:15
@yantosca yantosca self-assigned this Apr 6, 2023
@yantosca yantosca linked an issue Apr 6, 2023 that may be closed by this pull request
2 tasks
@yantosca yantosca mentioned this pull request Apr 6, 2023
3 tasks
Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks @yantosca. Looks good to merge.

@msulprizio msulprizio merged commit 24dbd07 into main Apr 6, 2023
@msulprizio msulprizio deleted the feature/dropdown branch April 6, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: CSS Pertaining to issues with CSS style sheets topic: Dropdown Menus Pertaining to issues with dropdown menus topic: Javascript Pertaining to issues with Javascript scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasionally unable to access dropdown menu items
2 participants