Fix maskInlineIgnore to handle non-ascii input #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug-fix
What is the current behavior? (You can also link to an open issue here)
#278 - Crash when running against non-ascii input.
What is the new behavior (if this is a feature change)?
No crash on non-ascii input.
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No
Other information:
The
maskInlineIgnore
would be converted to a slice of runes, but the length of a slice of runes is not equal to the length of a string when non-ascii characters are present. In the rune representation, each index element is a 32-bit code-point whilelen(string)
returns the number of bytes in the string. A good reference is https://go.dev/blog/stringsI've opted to use the already existing
ignoreRuleRegex
to replace the characters that were previously being replaced with null terminators. I've also added some tests for this.