chore(app): Insert Trades in batches

get10101 · Jun 4, 2024 · 9972e55 · 9972e55
1 parent c473330
commit 9972e55
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 15 deletions.
diff --git a/mobile/native/src/db/mod.rs b/mobile/native/src/db/mod.rs
@@ -497,10 +497,12 @@ pub fn get_all_trades() -> Result<Vec<crate::trade::Trade>> {
     Ok(trades)
 }
 
-pub fn insert_trade(trade: crate::trade::Trade) -> Result<()> {
+pub fn insert_trades(trades: &[crate::trade::Trade]) -> Result<()> {
     let mut db = connection()?;
 
-    NewTrade::insert(&mut db, trade.into())?;
+    let trades = trades.iter().copied().map(|trade| trade.into()).collect();
+
+    NewTrade::insert(&mut db, trades)?;
 
     Ok(())
 }

diff --git a/mobile/native/src/db/models.rs b/mobile/native/src/db/models.rs
@@ -1092,12 +1092,14 @@ impl Trade {
 }
 
 impl NewTrade {
-    pub fn insert(conn: &mut SqliteConnection, trade: Self) -> Result<()> {
+    pub fn insert(conn: &mut SqliteConnection, trades: Vec<Self>) -> Result<()> {
+        let len = trades.len();
+
         let affected_rows = diesel::insert_into(trades::table)
-            .values(trade)
+            .values(trades)
             .execute(conn)?;
 
-        ensure!(affected_rows > 0, "Could not insert trade");
+        ensure!(affected_rows > len, "Could not insert trade");
 
         Ok(())
     }

diff --git a/mobile/native/src/trade/position/handler.rs b/mobile/native/src/trade/position/handler.rs
@@ -4,7 +4,7 @@ use crate::event::EventInternal;
 use crate::trade::order::Order;
 use crate::trade::position::Position;
 use crate::trade::position::PositionState;
-use crate::trade::trades::handler::new_trade;
+use crate::trade::trades::handler::new_trades;
 use crate::trade::FundingFeeEvent;
 use anyhow::bail;
 use anyhow::Context;
@@ -182,9 +182,7 @@ pub fn update_position_after_dlc_channel_creation_or_update(
         }
     };
 
-    for trade in trades {
-        new_trade(trade)?;
-    }
+    new_trades(trades)?;
 
     event::publish(&EventInternal::PositionUpdateNotification(position));
 
@@ -227,9 +225,7 @@ pub fn update_position_after_dlc_closure(filled_order: Order) -> Result<()> {
         );
     }
 
-    for trade in trades {
-        new_trade(trade)?;
-    }
+    new_trades(trades)?;
 
     db::delete_positions()?;
 

diff --git a/mobile/native/src/trade/trades/handler.rs b/mobile/native/src/trade/trades/handler.rs
@@ -4,10 +4,12 @@ use crate::event::EventInternal;
 use crate::trade::Trade;
 use anyhow::Result;
 
-pub fn new_trade(trade: Trade) -> Result<()> {
-    db::insert_trade(trade)?;
+pub fn new_trades(trades: Vec<Trade>) -> Result<()> {
+    db::insert_trades(&trades)?;
 
-    event::publish(&EventInternal::NewTrade(trade));
+    for trade in trades {
+        event::publish(&EventInternal::NewTrade(trade));
+    }
 
     Ok(())
 }