Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not checking current state before state transition #2599

Closed
luckysori opened this issue Jun 4, 2024 · 2 comments
Closed

Consider not checking current state before state transition #2599

luckysori opened this issue Jun 4, 2024 · 2 comments

Comments

@luckysori
Copy link
Contributor

luckysori commented Jun 4, 2024

If we always assume that there is ever only one position, we might want to consider removing this filter as it would potentially only lead to errors if the position is not in the state we assume it should be.

Originally posted by @holzeis in #2584 (comment)

@holzeis
Copy link
Contributor

holzeis commented Jun 4, 2024

I guess that ticket will get obsolete once we get rid of the position state.

Copy link

github-actions bot commented Jul 5, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 5, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants