Funding fee feature #2584
Merged
Funding fee feature #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckysori
force-pushed
the
feat/funding-fee-extravaganza
branch
2 times, most recently
from
e39b523
to
279eb4e
Compare
holzeis
approved these changes
May 30, 2024
| /// Update the position after the rollover protocol has ended. | ||
| pub fn finish_rollover(conn: &mut SqliteConnection, updated_position: Position) -> Result<()> { | ||
| let affected_rows = diesel::update(positions::table) | ||
| .filter(positions::state.eq(PositionState::Rollover)) |
There was a problem hiding this comment.
If we always assume that there is ever only one position, we might want to consider removing this filter as it would potentially only lead to errors if the position is not in the state we assume it should be.
There was a problem hiding this comment.
That makes some sense. Although in theory we could be catching an actual error here.
There was a problem hiding this comment.
I opened an issue because I think your comment applies to other spots too: #2599.
| @@ -370,7 +377,11 @@ impl Node { | |||
| "Finished rollover protocol" | |||
| ); | |||
|
|
|||
| position::handler::set_position_state(PositionState::Open)?; | |||
| let position = update_position_after_rollover() | |||
There was a problem hiding this comment.
🔧 these two updates should probably run within the same database transaction.
There was a problem hiding this comment.
I totally agree, but this requires reworking get_positions, which is used in 11 spots.
This was referenced Jun 4, 2024
The `Position` model should be as strongly typed as possible. Converting to i64 should happen _just_ before inserting into the database.
This server can be used during local development to query the
coordinator database conveniently e.g.
```
$ curl http://localhost:3002/dlc_protocols | jq .
[
{
"id": 1,
"protocol_id": "fb4c6f27-db9d-4b2d-8539-6e609e1559b9",
"previous_protocol_id": null,
"channel_id": "f689230c5477176961301cb22093cfd52050a52356812039f9c298fe8859eba2",
"contract_id": "972c5fcafbd6bbbf874a9a5cd44d9ddd05a2e3f3ae96d5bd771e5af1b8cae1a6",
"protocol_state": "Success",
"trader_pubkey": "02e9f7a0e0d6eeab989dcbb4e91f0bf95f583b09d8d324cc9635807e844eea82bc",
"timestamp": "2024-05-13T05:32:36.452958+00:00",
"protocol_type": "open-channel"
}
]
```
It can also be used in the e2e tests to easily assert on the state of
the coordinator, without needing to add dedicated HTTP API endpoints.
It might even be used to modify the coordinator state to create
interesting test scenarios.
luckysori
force-pushed
the
feat/funding-fee-extravaganza
branch
from
279eb4e
to
9972e55
Compare
The coordinator generates funding fee events as funding rates are added to the database and applies them on rollover. The app displays funding fee events in a dedicated `Trades` tab, together with regular trades. The funding fee events are added as soon as the app learns about them from the coordinator, which is usually before they are resolved. Additionally, the app will update the position after rolling over based on the funding fee events that were resolved with the rollover. Missing bits: - Apply funding fee events on closing and resizing. - Considering funding fee events when deciding if positions need to be liquidated. - Add some unit tests. - Expanding e2e tests. - Add fee rate to app's `Trades` tab. - Display next fee rate in app's `Trade` screen. Co-authored-by: Philipp Hoenisch <[email protected]>
We only support one position at a time at the moment. Co-authored-by: Richard Holzeis <[email protected]>
luckysori
force-pushed
the
feat/funding-fee-extravaganza
branch
from
9972e55
to
3a85bee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/get10101/meta/issues/330.
Fixes #2535.
Supersedes #2532.
Sorry for the ginormous PR. I tried to build on top of #2532, but too many things changed.
The main patch is c3e5ee8. To be fair, some things do change slightly in the patches that follow that one, so patch by patch review is not ideal. But I think it's good enough.
I think this feature can be deployed if we don't find any flaws, but there are some missing bits: