Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify traders when new funding rates are added #2608

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

luckysori
Copy link
Contributor

Follow up to #2584.

It makes more sense to have the "domain" models on top of the database
models, as opposed to next to them.

The next patch should highlight why this is useful.
After an update to the `funding_rates` table, there is no guarantee
that the next funding rate has changed, but sending the message
unconditionally is simpler and should cause no problems.
@luckysori luckysori requested review from bonomat and holzeis June 5, 2024 06:31
@luckysori luckysori self-assigned this Jun 5, 2024
Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luckysori luckysori added this pull request to the merge queue Jun 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2024
@luckysori luckysori added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit f1167fd Jun 5, 2024
24 checks passed
@luckysori luckysori deleted the feat/notify-traders-on-new-funding-rate branch June 5, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants