fix: Stop welcome screen overflowing #2595
Conversation
| final Widget child; | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| return SafeArea( | ||
| bottom: bottom, |
There was a problem hiding this comment.
This is to pass it through from this.bottom. The reason I did bottom: bottom instead of bottom: this.bottom is because the IDE recommended that it was less redundant/better style. It's set in the welcome screen. If it's not needed there though it could be removed
There was a problem hiding this comment.
I wanted to know what the bottom flag is telling the SafeArea widget, but I've looked it up now.
Whether to avoid system intrusions on the bottom side of the screen.
Do we need this if the area is anyways scrollable?
There was a problem hiding this comment.
Do we need this if the area is anyways scrollable?
I simply kept it as it was in the original and I was not sure what behaviour or display may change with removing it. I'm happy to remove it if you'd like.
FWIW the page did not fit on my phone as-is so it's probably good that it's scrollable now 😅
holzeis
changed the title
Fixes #2405