Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mobile): prevent set budget amount zero #346

Merged
merged 1 commit into from
Sep 21, 2024
Merged

fix(mobile): prevent set budget amount zero #346

merged 1 commit into from
Sep 21, 2024

Conversation

bkdev98
Copy link
Member

@bkdev98 bkdev98 commented Sep 21, 2024 •
edited
Loading

Resolves #322

@bkdev98 bkdev98 mentioned this pull request Sep 21, 2024
Merged
@bkdev98 bkdev98 added the frontend label Sep 21, 2024 — with Graphite App
@bkdev98 bkdev98 added the enhancement New feature or request label Sep 21, 2024 — with Graphite App
@bkdev98 bkdev98 mentioned this pull request Sep 21, 2024
Merged
@bkdev98 Graphite App
Copy link
Member Author

bkdev98 commented Sep 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bkdev98 and the rest of your teammates on Graphite Graphite

@bkdev98 bkdev98 mentioned this pull request Sep 21, 2024
Merged
@bkdev98 bkdev98 removed the enhancement New feature or request label Sep 21, 2024
@bkdev98 bkdev98 added the bug Something isn't working label Sep 21, 2024 — with Graphite App
@bkdev98 bkdev98 marked this pull request as ready for review September 21, 2024 12:41
This was referenced Sep 21, 2024
Merged
Merged
Merged
@bkdev98 bkdev98 force-pushed the 09-21-feat_mobile_slightly_increase_font_size branch from 562e840 to f3984c8 Compare September 21, 2024 15:50
@bkdev98 bkdev98 force-pushed the 09-21-fix_mobile_prevent_set_budget_amount_zero branch from ccaa744 to 60ea3c5 Compare September 21, 2024 15:50
@graphite-app graphite-app bot requested a review from duongdev September 21, 2024 15:50
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 21, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/21/24)

2 reviewers were added to this PR based on Dustin Do's automation.

@bkdev98 Graphite App
Copy link
Member Author

bkdev98 commented Sep 21, 2024 •
edited
Loading

Merge activity

  • Sep 21, 12:19 PM EDT: @bkdev98 started a stack merge that includes this pull request via Graphite.
  • Sep 21, 12:27 PM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 21, 12:28 PM EDT: @bkdev98 merged this pull request with Graphite.

@bkdev98 bkdev98 changed the base branch from 09-21-feat_mobile_slightly_increase_font_size to graphite-base/346 September 21, 2024 16:23
@bkdev98 bkdev98 changed the base branch from graphite-base/346 to main September 21, 2024 16:25
@bkdev98 bkdev98 force-pushed the 09-21-fix_mobile_prevent_set_budget_amount_zero branch from 60ea3c5 to f5bad30 Compare September 21, 2024 16:26
@bkdev98 bkdev98 merged commit a233ddb into main Sep 21, 2024
5 checks passed
@bkdev98 bkdev98 deleted the 09-21-fix_mobile_prevent_set_budget_amount_zero branch September 21, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duongdev duongdev Awaiting requested review from duongdev

Assignees
No one assigned
Labels
bug Something isn't working frontend
Projects
6pm
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Budget][FE] Budget item shows "NaN%" when setting budget amount to 0
1 participant
@bkdev98