-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add push notifications #163
Draft
reneaaron
wants to merge
30
commits into
master
Choose a base branch
from
feat/push-notifications
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneaaron
force-pushed
the
feat/push-notifications
branch
from
October 31, 2024 09:38
0289ded
to
1c6e544
Compare
feat: notification improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
usernotifications.filtering
entitlement (also needs feat: add filtering option nikwebr/expo-notification-service-extension-plugin#1)Description
Testing
Replace
NOSTR_API_URL
to local http-nostr urlRun feat: add endpoint for registering alby go notifications http-nostr#128 and use
ngrok http 8888
Copy the ngrok link to NOSTR_API_URL in constants
If running on android, download
google-services.json
from firebase console and add it to the root of your directory and set this in your .env.local:GOOGLE_SERVICES_JSON=./google-services.json
Connect your device via cable and run yarn install and then
npx expo run:ios --device
/npx expo run:android --device
Enable notifications in settings and receive a transaction to get notified (tapping on the notification also switches to the right wallet and takes you to the transaction screen)