chore: separate create invoice screen from receive #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Dec 22, 2024
| import { errorToast } from "~/lib/errorToast"; | ||
| import { useAppStore } from "~/lib/state/appStore"; | ||
|
|
||
| export function CreateInvoice() { |
There was a problem hiding this comment.
This page does more than just creating an invoice, is there a better name for it?
rolznz
reviewed
Dec 22, 2024
| @@ -77,92 +35,11 @@ export function Receive() { | |||
| }); | |||
| } | |||
|
|
|||
| // TODO: move this somewhere else to have app-wide notifications of incoming payments | |||
There was a problem hiding this comment.
Maybe we can address this to show a toast whenever we get a payment? because received payments via lightning address will not show any more - we are removing a feature here.
There was a problem hiding this comment.
Then we can make this provider which keeps pushing notifications via toast in-app (everywhere, not just receive), will add a commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Receivescreen similar toSend, so now Create Invoice screen is separatedScreenshots