Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delay camera #76

Merged
merged 4 commits into from
Sep 3, 2024
Merged

fix: delay camera #76

merged 4 commits into from
Sep 3, 2024

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented Sep 3, 2024

Currently there is a problem if you install the app for the first time:

The camera permission prompt is raised directly (and not only after you proceed to the next screen)

In the layout we wait for the rootNavigationState before we do the redirect to circumvent a problem with redirects happening before the first render. So this means the ConnectWallet screen is rendered (but immediately replaced with the `Onboarding screen), which triggers the camera prompt.

Now I introduced a new Index route, where we check for the onboarding status and redirect to the respective page.

After many failed attempts this seems to be a solution that works reliably.

Update: Refactored to another approach using a hook and removing the new index route

@reneaaron reneaaron marked this pull request as ready for review September 3, 2024 14:36
@reneaaron reneaaron merged commit 9effdb2 into master Sep 3, 2024
1 check passed
@im-adithya im-adithya deleted the fix/delay-camera branch November 18, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant