Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and refactor Permissions logic #76

Closed
im-adithya opened this issue Jun 6, 2024 · 3 comments
Closed

Review and refactor Permissions logic #76

im-adithya opened this issue Jun 6, 2024 · 3 comments
Assignees

Comments

@im-adithya
Copy link
Member

im-adithya commented Jun 6, 2024

Currently permissions editing is decided by request_methods in the query params, we should change this.

It can be based on individual params but again there should be a unified editing state (or not?)

@rolznz
Copy link
Contributor

rolznz commented Jun 7, 2024

As part of this we should try fix this bug where you cannot see the custom amount:

I noticed, there's also a bug in the form if you set max_amount=100 on its own. You cannot see the set amount - just none of the boxes are selected.

From getAlby/nostr-wallet-connect-next#377 (comment)

@im-adithya
Copy link
Member Author

Needs design input from @stackingsaunter

@im-adithya im-adithya transferred this issue from getAlby/nostr-wallet-connect-next Jul 5, 2024
@rolznz
Copy link
Contributor

rolznz commented Jul 18, 2024

Completed in #14 / #273

@rolznz rolznz closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants