Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

feat: revamp new app screen #520

Closed
wants to merge 1 commit into from
Closed

feat: revamp new app screen #520

wants to merge 1 commit into from

Conversation

im-adithya
Copy link
Member

@rolznz
Copy link
Collaborator

rolznz commented Jun 27, 2024

@im-adithya are there supposed to be both permissions and scopes components? shouldn't you have renamed the permissions file to scopes so that there is a nice diff of the changes?

I think we should merge #508 first as we need to fix an issue with BTCPayServer and then fix the conflicts here.

@im-adithya
Copy link
Member Author

Yeah, I will. I left this in between to prioritize the Send/Receive.

I was thinking of removing the use of Permissions component and doing a normal forEach listing of scopes in the ShowApp screen. So after this PR, the Scopes component would only be there to extract the scope group boxes (refer new design) and checkboxes out of the NewApp screen, and all the other permissions logic would be in NewApp itself

@im-adithya
Copy link
Member Author

Closing in favor of #567

@im-adithya im-adithya closed this Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and refactor Permissions logic
2 participants