feat: fire events on failed sync #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there anything else that we can do? what does the user then need to do? restart? |
If it's a temporary issue on startup (e.g. they run Alby Hub locally and have a bad internet connection) then yes, they can just try again. If it fails consistently though or for multiple users, it would be a good indicator there is something wrong on our side that we need to look into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we need better monitoring of core parts of our system. If syncs fail we need to quickly be notified and check our electrs service, or reach out to users who may be unable to sync for whatever other reason and provide as much help as we can.