Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: appcard improvements & linking account #235

Merged
merged 7 commits into from
Jul 11, 2024

Conversation

reneaaron
Copy link
Contributor

No description provided.

@reneaaron reneaaron marked this pull request as ready for review July 10, 2024 07:17
@rolznz
Copy link
Contributor

rolznz commented Jul 10, 2024

image

@reneaaron @stackingsaunter can we adjust the illustration a bit? I think if it had links to a lightning address, a podcasting app, etc. it would be much easier to understand.

Right now it's just a button with a cursor on it

alby/models.go Outdated Show resolved Hide resolved
@reneaaron
Copy link
Contributor Author

image

@reneaaron @stackingsaunter can we adjust the illustration a bit? I think if it had links to a lightning address, a podcasting app, etc. it would be much easier to understand.

Right now it's just a button with a cursor on it

How about this one?

image

@rolznz
Copy link
Contributor

rolznz commented Jul 10, 2024

image

Weird "dai" instead of "daily"

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@bumi
Copy link
Contributor

bumi commented Jul 10, 2024

<3

@stackingsaunter
Copy link
Contributor

Updated illustration @reneaaron

alby-account-mobile-hub
alby-account-mobile-hub

@rolznz rolznz merged commit 060087b into master Jul 11, 2024
7 of 8 checks passed
@rolznz rolznz deleted the feat/appcard-improvements branch July 11, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants