Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate theme from storage #244

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented Jul 10, 2024

Partly fixes #221

Older hubs had "dark" saved as the ui theme which now was rename to a explicit darkmode setting, however there is no theme named "dark". Thus the theme appears broken if you upgrade an older version of the hub, for new installs it should be fine.

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@reneaaron reneaaron merged commit 5a7b68a into master Jul 10, 2024
7 of 8 checks passed
@reneaaron reneaaron deleted the fix/validate-theme-from-storage branch July 10, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clouds not showing in onboarding any more (only when system appearance = light mode)
2 participants