Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use proper title in wails #662

Merged
merged 1 commit into from
Oct 22, 2024
Merged

chore: use proper title in wails #662

merged 1 commit into from
Oct 22, 2024

Conversation

im-adithya
Copy link
Member

@im-adithya im-adithya commented Sep 18, 2024

Changes the title from albyhub in wails app to Alby Hub

Also fixes #466

@im-adithya im-adithya marked this pull request as draft September 18, 2024 11:28
@bumi
Copy link
Contributor

bumi commented Sep 21, 2024

is this good already?

@rolznz
Copy link
Contributor

rolznz commented Sep 24, 2024

Related: #695

@im-adithya im-adithya marked this pull request as ready for review September 26, 2024 06:30
@im-adithya
Copy link
Member Author

im-adithya commented Sep 26, 2024

⚠️ Wails apps need testing in

  • Windows
  • Linux
  • MacOS

@im-adithya im-adithya changed the title chore: use proper title in wails chore: use proper title in wails and add version to artifacts Sep 27, 2024
else
echo "PACKAGE_NAME=albyhub-Server-Linux-${{ matrix.build.arch }}" >> $GITHUB_ENV
echo "PACKAGE_NAME=AlbyHub-Server-Linux-${{ matrix.build.arch }}-${SANITIZED_TAG}" >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work with our server update script?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think file names should always be lowercased. If we change it then let's make sure everything is lowercase, then we less likely have issues on case-sensitive systems.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, changing it to be lowercase 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the only issue. I think the Alby download links are to exact filenames, but now we add a version suffix on the filename. I think a change in getalby.com is also needed to ensure it picks up the file.

I originally suggested this because downloading two versions with the same filename ends up suffixing the second one with a (1).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally suggested this because downloading two versions with the same filename ends up suffixing the second one with a (1).

that's the reason why we add the version number to the filename? why would a user do that and even if the user does that why would it be a a problem?

@rolznz
Copy link
Contributor

rolznz commented Oct 4, 2024

Tested the Linux Desktop build, it seems to work well. I'm not sure we should do the same for the server builds though, will this create issues with our scripts? CC @bumi

@bumi
Copy link
Contributor

bumi commented Oct 8, 2024

if we change the package name, then let's make sure we're using also the lowercased version in the scripts (need to be searched here in the repo and on getalbycom)

@bumi
Copy link
Contributor

bumi commented Oct 8, 2024

ok, I missed the addition of the version to the filename. to me this just makes everything more complicated and then every script any everything needs to be aware of the changing filename.

@im-adithya im-adithya changed the title chore: use proper title in wails and add version to artifacts chore: use proper title in wails Oct 22, 2024
@im-adithya
Copy link
Member Author

Removed adding version to file names and restricted to only fixing the app name in wails from "albyhub" to "Alby Hub"

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

I tested the Wails build already on Linux with the last version which worked ok. I don't think anything has changed since then

@rolznz rolznz added this to the v1.10.3 milestone Oct 22, 2024
@rolznz rolznz merged commit eaab2d8 into master Oct 22, 2024
9 checks passed
@rolznz rolznz deleted the task-name branch October 22, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add version number to release artifacts
3 participants