Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not require unlock password to recover encrypted scb #768

Merged
merged 10 commits into from
Nov 1, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Oct 30, 2024

This PR changes the how the Alby Account - specific static channel backups are encrypted to no longer require the unlock password, by deriving it from the seed. Therefore, the user only needs to backup their recovery phrase.

TODOs:

  • change encryption (no need to re-generate key)
  • should mnemonic exist for all backend types? not solving in this PR
  • review derivation logic
  • update derivation paths
    • It's very unlikely, but possible, that a given index does not produce a valid private key. Error checking is skipped in this example for brevity but should be handled in real code. In such a case, a ErrInvalidPrivateKey is returned. - what to do here if we use a hardcoded index for the backup? wait for the issue to happen (this will occur on node startup if ever, since we also store a channel backup on node startup)?
  • review change to channel backup description
  • update copy on backup page
  • local E2E test

service/keys/keys.go Outdated Show resolved Hide resolved
service/keys/keys.go Outdated Show resolved Hide resolved
service/keys/keys.go Outdated Show resolved Hide resolved
config/aesgcm.go Show resolved Hide resolved
@rolznz rolznz added this to the v1.10.4 milestone Oct 31, 2024
@rolznz rolznz marked this pull request as ready for review October 31, 2024 16:17
alby/alby_oauth_service_test.go Outdated Show resolved Hide resolved
alby/alby_oauth_service_test.go Outdated Show resolved Hide resolved
@rolznz rolznz merged commit 7ec4746 into master Nov 1, 2024
9 checks passed
@rolznz rolznz deleted the feat/improved-encrypted-channel-backups branch November 1, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants