Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: health check endpoint #971

Merged
merged 5 commits into from
Jan 17, 2025
Merged

feat: health check endpoint #971

merged 5 commits into from
Jan 17, 2025

Conversation

rdmitr
Copy link
Collaborator

@rdmitr rdmitr commented Jan 10, 2025

Closes #957
Closes #175

image

image

@rdmitr rdmitr requested a review from rolznz January 10, 2025 07:00
api/api.go Outdated Show resolved Hide resolved
@rdmitr rdmitr linked an issue Jan 10, 2025 that may be closed by this pull request
@rolznz rolznz self-assigned this Jan 13, 2025
@rolznz
Copy link
Contributor

rolznz commented Jan 13, 2025

@rdmitr I removed the peers offline check as it does mean the node is not functional, I think the channels offline one is sufficient.

I also removed some of the rawDetails (especially because most of them are unmapped, and maybe we do not need such an advanced UI).

@rolznz rolznz requested a review from reneaaron January 13, 2025 13:43
@rolznz
Copy link
Contributor

rolznz commented Jan 13, 2025

@reneaaron I did a first effort at the most basic UI, maybe we could huddle to review.

If there are no alarms, the health check will be green.

Things I think are not so great:

  • It's just a tooltip - you cannot click it and probably users will not know what to do next.
  • The Alby services one is vague and could be improved by reading the incidents, but probably we do not want to spend too much time on services being down.

@rolznz
Copy link
Contributor

rolznz commented Jan 17, 2025

Merging for now, we can do a follow-up iteration with @stackingsaunter 's design when it is ready

@rolznz rolznz merged commit ff9ef56 into master Jan 17, 2025
10 checks passed
@rolznz rolznz deleted the feat/health-check branch January 17, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDK: connect to peers on startup in separate goroutine Add healthcheck endpoint
2 participants