Merge pull request #222 from getAlby/fix/examples-crypto-nodejs-20

Fix: examples for nodeJS 20+
getAlby · Jun 3, 2024 · f7a85c0 · f7a85c0
2 parents d89e0f5 + d8559c5
commit f7a85c0
Show file tree

Hide file tree

Showing 25 changed files with 28 additions and 47 deletions.
diff --git a/README.md b/README.md
@@ -164,7 +164,7 @@ import "websocket-polyfill";
 // or: require('websocket-polyfill');
 ```
 
-if you get an `crypto is not defined` error you have to import it first:
+if you get an `crypto is not defined` error, either upgrade to node.js 20 or above, or import it manually:
 
 ```js
 import * as crypto from 'crypto'; // or 'node:crypto'

diff --git a/examples/crypto-polyfill.js b/examples/crypto-polyfill.js
@@ -0,0 +1,4 @@
+import * as crypto from "node:crypto"; // required in node.js < 20
+if (!global.crypto) {
+  global.crypto = crypto;
+}
diff --git a/examples/nwc/client/get-balance.js b/examples/nwc/client/get-balance.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/get-info.js b/examples/nwc/client/get-info.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/get-wallet-service-info.js b/examples/nwc/client/get-wallet-service-info.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/get-wallet-service-supported-methods.js b/examples/nwc/client/get-wallet-service-supported-methods.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/list-transactions.js b/examples/nwc/client/list-transactions.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/lookup-invoice.js b/examples/nwc/client/lookup-invoice.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/make-invoice.js b/examples/nwc/client/make-invoice.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/multi-pay-invoice.js b/examples/nwc/client/multi-pay-invoice.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import { LightningAddress } from "@getalby/lightning-tools";

diff --git a/examples/nwc/client/multi-pay-keysend.js b/examples/nwc/client/multi-pay-keysend.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/pay-invoice.js b/examples/nwc/client/pay-invoice.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/pay-keysend.js b/examples/nwc/client/pay-keysend.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/sign-message.js b/examples/nwc/client/sign-message.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/client/subscribe.js b/examples/nwc/client/subscribe.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/get-balance.js b/examples/nwc/get-balance.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/get-info.js b/examples/nwc/get-info.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/keysend.js b/examples/nwc/keysend.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/list-transactions.js b/examples/nwc/list-transactions.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/lookup-invoice.js b/examples/nwc/lookup-invoice.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/make-invoice.js b/examples/nwc/make-invoice.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/multi-keysend.js b/examples/nwc/multi-keysend.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/send-multi-payment.js b/examples/nwc/send-multi-payment.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import { LightningAddress } from "@getalby/lightning-tools";

diff --git a/examples/nwc/send-payment.js b/examples/nwc/send-payment.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";

diff --git a/examples/nwc/sign-message.js b/examples/nwc/sign-message.js
@@ -1,5 +1,4 @@
-import * as crypto from "node:crypto"; // required in node.js
-global.crypto = crypto; // required in node.js
+import "../crypto-polyfill.js";
 import "websocket-polyfill"; // required in node.js
 
 import * as readline from "node:readline/promises";