Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump nostr-tools from 1.13.1 to 1.17.0 #104

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2023

Bumps nostr-tools from 1.13.1 to 1.17.0.

Commits
  • 318e3f8 we don't have to bump to 2.0.0 since this will not break backwards-compatibil...
  • 894ffff prefix exported modules with ./ (esbuild requires this apparently).
  • ce11a5f Organize build, allow one entrypoint per file (#305)
  • 5e85bbc Fix nip44 vectors (#308)
  • eb0a909 Implement NIP-44: secure versioned replacement for NIP4 (#221)
  • c73268c Add kind to nevent decode and encode (#304)
  • 6874f58 apply prettier.
  • e899cc3 edit batchedList and add mergeFilters to it
  • de72172 add helper functions for nip-47
  • 073dcaa Update README.md
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 16, 2023
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nostr-tools-1.17.0 branch 3 times, most recently from a9bfeda to f5c8846 Compare October 17, 2023 08:55
Bumps [nostr-tools](https://github.com/nbd-wtf/nostr-tools) from 1.13.1 to 1.17.0.
- [Commits](nbd-wtf/nostr-tools@v1.13.1...v1.17.0)

---
updated-dependencies:
- dependency-name: nostr-tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/nostr-tools-1.17.0 branch from f5c8846 to 91c6ab0 Compare October 17, 2023 08:58
@pavanjoshi914
Copy link
Contributor

i remember previously we not chose to upgrade nostr-tools! this contains breaking changes as they remove events "pub.on" which catches response after publishing the event. we need something our own here

@rolznz @bumi are we planning to upgrade this and change code ?

nbd-wtf/nostr-tools@9d69081#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L112

@rolznz
Copy link
Contributor

rolznz commented Oct 17, 2023

@pavanjoshi914 yes, we need to update it and make the necessary code changes. So now if the promise resolves we assume the event was published, otherwise an error will be thrown?

@rolznz
Copy link
Contributor

rolznz commented Nov 17, 2023

Fixed in #137

@rolznz rolznz closed this Nov 17, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 17, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/nostr-tools-1.17.0 branch November 17, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants