Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add NWC sign message method #216

Merged
merged 2 commits into from
Apr 10, 2024
Merged

feat: add NWC sign message method #216

merged 2 commits into from
Apr 10, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Mar 31, 2024 •
edited
Loading

Related to getAlby/hub#185

  • propose method to NIP-47?

Example output:

node examples/nwc/sign-message.js 
{
  message: 'Hello, world!',
  signature: 'd9s5fyzwmjpyxej81kaz1iqqhn356epba4eokducjwc3n517dbg1sopi9hqkjunhpx5af4hxo9xrzx3y95x4ra73fko1qpffuajio1au'
}

@rolznz rolznz mentioned this pull request Mar 31, 2024
Merged
@reneaaron
Copy link
Contributor

Cool, that way we could potentially offer signMessage in the extension through NWC again, right? 🚀

utACK

@pavanjoshi914
Copy link
Contributor

@rolznz tried connecting alby hub with extension. works great!!
image

pavanjoshi914
pavanjoshi914 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@rolznz rolznz merged commit f55216d into master Apr 10, 2024
3 checks passed
@pavanjoshi914 pavanjoshi914 deleted the feat/sign-message branch April 10, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavanjoshi914 pavanjoshi914 pavanjoshi914 approved these changes

@bumi bumi Awaiting requested review from bumi

@im-adithya im-adithya Awaiting requested review from im-adithya

@reneaaron reneaaron Awaiting requested review from reneaaron

Assignees

@pavanjoshi914 pavanjoshi914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolznz @reneaaron @pavanjoshi914