Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add volume check while creating invoice #458

Closed
wants to merge 3 commits into from
Closed

chore: add volume check while creating invoice #458

wants to merge 3 commits into from

Conversation

im-adithya
Copy link
Member

Fixes #457

Adds volume check to invoice creation endpoints (v1 and v2)

@im-adithya im-adithya requested review from bumi and kiwiidb November 29, 2023 08:13
rolznz
rolznz reviewed Nov 29, 2023
View reviewed changes
controllers/invoice.ctrl.go Outdated Show resolved Hide resolved
@kiwiidb kiwiidb self-requested a review November 29, 2023 10:42
kiwiidb
kiwiidb suggested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@kiwiidb kiwiidb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another endpoint where this should be added, in addinvoice.ctrl.go

@kiwiidb
Copy link
Contributor

kiwiidb commented Dec 1, 2023

Superseded by #462

@kiwiidb kiwiidb closed this Dec 1, 2023
@kiwiidb kiwiidb deleted the task-volume-invoice branch December 1, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolznz rolznz rolznz left review comments

@kiwiidb kiwiidb kiwiidb approved these changes

@bumi bumi Awaiting requested review from bumi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MAX_VOLUME check to invoice creation
3 participants
@im-adithya @kiwiidb @rolznz