This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
forked from getAlby/nostr-wallet-connect
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be added in nostr-protocol/nips#1164
|
@im-adithya can you update this PR? |
Done! |
rolznz
reviewed
Jun 20, 2024
rolznz
reviewed
Jun 20, 2024
rolznz
reviewed
Jun 20, 2024
@im-adithya @bumi I looked at the rails code and it seems to look ok to handle both incoming and outgoing invoices without any changes I'm merging this now. In case you have any feedback, let me know and I'll address it in a follow up PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes getAlby/hub#64 | Adds support for
payment_sent
notificationjs-sdk
PR: feat: add payment_sent notification js-sdk#223Testing