fix: Revert "fix: Fix caching of unparseable SQL"

This reverts commit e81db08.
getappmap · Aug 24, 2023 · 384f077 · 384f077
1 parent 220a6de
commit 384f077
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/packages/scanner/src/appMapIndex.ts b/packages/scanner/src/appMapIndex.ts
@@ -3,7 +3,7 @@ import { QueryAST } from './types';
 import LRUCache from 'lru-cache';
 
 const NormalizedSQLBySQLString = new LRUCache<string, string>({ max: 10000 });
-const ASTBySQLString = new LRUCache<string, QueryAST | 'parse-error'>({ max: 1000 });
+const ASTBySQLString = new LRUCache<string, QueryAST>({ max: 1000 });
 
 export default class AppMapIndex {
   constructor(public appMap: AppMap) {}
@@ -12,17 +12,12 @@ export default class AppMapIndex {
     if (!event.sql) throw new Error(`${event.fqid} is not a SQL query`);
 
     const sql = this.sqlNormalized(event);
-    let result: QueryAST | undefined;
-    const cachedAST = ASTBySQLString.get(sql);
-    if (cachedAST === 'parse-error') {
-      result = undefined;
-    } else if (cachedAST) {
-      result = cachedAST;
-    } else {
-      result = parseSQL(sql);
-      ASTBySQLString.set(sql, result ? result : 'parse-error');
+    let ast = ASTBySQLString.get(sql);
+    if (!ast) {
+      ast = parseSQL(sql);
+      ast ? ASTBySQLString.set(sql, ast) : ASTBySQLString.set(sql, null);
     }
-    return result;
+    return ast;
   }
 
   sqlNormalized(event: Event): string {