feat: Apply saved filters #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilpin
force-pushed
the
feat/apply-saved-filters
branch
from
e0662c5
to
b6d2647
Compare
In ChatSearch
Closed
kgilpin
force-pushed
the
feat/apply-saved-filters
branch
from
968c857
to
6b6bfef
Compare
It's never used and it's not worth the real estate.
kgilpin
force-pushed
the
feat/apply-saved-filters
branch
from
08c0b08
to
a946114
Compare
1 task
dustinbyrne
reviewed
Jan 11, 2024
| @@ -221,6 +221,15 @@ export default { | |||
| }, | |||
| }, | |||
| methods: { | |||
| getAppMapState() { | |||
| return this.$refs.vappmap?.getState(); | |||
There was a problem hiding this comment.
FYI, I've noticed something's up with the optional chaining operator. It should transpile correctly into the distribution bundle, but it throws an error in Storybook.
There was a problem hiding this comment.
This is used in a method, so it should be fine.
There was a problem hiding this comment.
Ok - do I need to change it or not? :-)
dustinbyrne
approved these changes
Jan 11, 2024
|
🎉 This PR is included in version @appland/components-v3.24.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The primary change in this PR is to enable the ChatSearch page to accept and handle
savedFilters, so that filter can be synchronized with the container environment (e.g. code editor).Basic "Navie" styling is also added.
The "Hide unlabeled" filter is removed from the UI, because it consumes vertical space and hasn't proven to be useful.
AppMap uploading / sharing is removed, since this feature is no longer supported by the server or by the IDE plugins.
Dependency of
getappmap/vscode-appland#859