feat: Upgrade search #2079
Merged
feat: Upgrade search #2079
+3,485
−1,141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilpin
force-pushed
the
feat/upgrade-search
branch
from
8d8c64e
to
406203d
Compare
|
Looking good, and I'm glad to see search getting its own package 👍. I've had similar thoughts about pulling out the local/remote Navie clients. |
|
Cool; I was wondering how you’d feel about that. The CLI package is so crowded. It does add overhead to update versions for release though. |
kgilpin
force-pushed
the
feat/upgrade-search
branch
from
0f726f1
to
01cda28
Compare
dustinbyrne
force-pushed
the
feat/upgrade-search
branch
from
9892d01
to
fb9ce12
Compare
kgilpin
force-pushed
the
feat/upgrade-search
branch
from
3ef60f6
to
db0ffdd
Compare
|
I've tested this in the benchmark and it adds about 1% to the solve rate. So, good to merge. |
kgilpin
force-pushed
the
feat/upgrade-search
branch
from
db0ffdd
to
b97c3c6
Compare
Also drop unused dependencies
kgilpin
force-pushed
the
feat/upgrade-search
branch
from
b97c3c6
to
9006278
Compare
|
🎉 This PR is included in version @appland/search-v1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @appland/appmap-v3.173.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Full-text search is refactored out into its own package,
@appland/search. In addition, the search functionality is upgraded and improved in a couple of different ways. Aside from these improvements, the code is generally moved over from@appland/appmap.Inclusion of all document words
All document words are now included in the index. This is an upgrade from current behavior with source code files, in which only the file path and recognized symbols are indexed.
Symbols are detected in the same ways as with the current behavior. Then, the document is split into words. Each word that is already recognized as a symbol is removed from the word list, so that it's not double-counted.
Weighted terms
Each source file index entry includes three separate columns, which are essentially:
weight=3weight=2weight=1SQLite query syntax makes it possible to perform a weighted search over the file path, symbols, and words.
Boost factors
Each document can also be associated with a row in the boost factors table. This feature makes it possible to boost search results based on external factors. The intended usage for this feature is to boost the source files and snippets that appear in AppMap trace data files. Boost can also be applied based on other external factors, such as presence of a file in a relevant log entry, backtrace, or APM data file (to name three examples).
Search exports
@appland/searchexports functions and constants that can be used externally to perform a search. Most optional behavior is controlled by passing in a function that matches a particular type signature. Concrete implementations of these functions are provided, but not assigned by default.