feat: Disable the selection of help mode by default #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilpin
force-pushed
the
feat/remove-autoenable-help-2182
branch
from
a5cf17a to
a0f71fc
Compare
dustinbyrne
reviewed
Jan 8, 2025
| this._browser = await puppeteer.launch({ | ||
| timeout: 120 * 1000, | ||
| headless: !this.showBrowser, | ||
| args: ['--no-sandbox'], |
There was a problem hiding this comment.
I ended up skipping the test that broke instead of disabling the sandbox. It's in main now, but feel free to replace it with this.
There was a problem hiding this comment.
The ruby action is fixed as well. I'm not sure why these decided to break all of a sudden.
This is an inherently safe operation anyway
kgilpin
force-pushed
the
feat/remove-autoenable-help-2182
branch
from
a0f71fc to
ca372b2
Compare
dustinbyrne
approved these changes
Jan 13, 2025
|
🎉 This PR is included in version @appland/appmap-v3.181.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2182