disable parameter rendering by default #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, parameters will no longer be rendered as strings by default. To see the values of parameters, APPMAP_DISPLAY_PARAMS must be set to "true".
Cache the value computed for root_dir. Note that there are many tests that expect to set root dir (by passing cwd to __init__), which show that the cached value is managed correctly. Also, cache is_appmap_repo. Its value is never reset.
dustinbyrne
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, parameters will no longer be rendered as strings by default.
To see the values of parameters, APPMAP_DISPLAY_PARAMS must be set to
"true".
Fixes #360.