feat: open exported svg in browser

getappmap · Mar 2, 2023 · 65dcd26 · 65dcd26
1 parent 755b254
commit 65dcd26
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/src/editor/appmapEditorProvider.ts b/src/editor/appmapEditorProvider.ts
@@ -12,6 +12,9 @@ import { getStackLocations, StackLocation } from '../lib/getStackLocations';
 import { ResolvedFinding } from '../services/resolvedFinding';
 import getWebviewContent from '../webviews/getWebviewContent';
 import ErrorCode from '../telemetry/definitions/errorCodes';
+import { promisify } from 'util';
+import { tmpName } from 'tmp';
+import { writeFile } from 'fs/promises';
 
 export type FindingInfo = ResolvedFinding & {
   stackLocations?: StackLocation[];
@@ -223,16 +226,12 @@ export default class AppMapEditorProvider
           {
             try {
               const { svgString } = message;
+              console.log('exportSVG received');
               if (svgString) {
-                const comment =
-                  '\n<!-- Save this SVG file with a .svg file extension ' +
-                  'and then open it in a web browswer to view your appmap! -->\n\n';
-                const document = await vscode.workspace.openTextDocument({
-                  language: 'svg',
-                  content: comment + svgString,
-                });
-
-                vscode.window.showTextDocument(document);
+                const diagramFile = (await promisify(tmpName)()) + '.svg';
+                await writeFile(diagramFile, svgString);
+                const uri = vscode.Uri.file(diagramFile);
+                vscode.env.openExternal(uri);
                 Telemetry.sendEvent(EXPORT_SVG);
               }
             } catch (e) {