Skip to content

Commit

Permalink
ci: Don't bother mocking os.homedir
Browse files Browse the repository at this point in the history
Presumably this is to direct the appmap.jar to a known location.
But these tests aren't actually verifying anything about the JAR.
And, every other instance of VSCode that gets launched is going
to also try and update that JAR file in $HOME/.appmap - so we may
as well let these tests do it too.
  • Loading branch information
kgilpin committed Jun 26, 2023
1 parent 4b69973 commit c44c7b9
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion test/integration/runConfigs/runConfigsJava.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ describe('run config service in a Java Project', () => {
await initializeWorkspace();

sinon = createSandbox();
sinon.stub(os, 'homedir').returns(ProjectJava);

// This needs to be faked because the Test Runner for Java extension is not installed during testing
// and VS Code will throw an error when attempting to update an unregistered config ("java.test.config")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ describe('run config service in a Java Project without the Test Runner for Java
await initializeWorkspace();

sinon = createSandbox();
sinon.stub(os, 'homedir').returns(ProjectJava);

fakeConfigGetSpy = sinon.spy(FakeConfig, 'get');
fakeConfigUpdateSpy = sinon.spy(FakeConfig, 'update');
Expand Down
1 change: 0 additions & 1 deletion test/integration/runConfigs/runConfigsRuby.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ describe('run config service in a Ruby project', () => {
await initializeWorkspace();

sinon = createSandbox();
sinon.stub(os, 'homedir').returns(ProjectA);

fakeConfigGetSpy = sinon.spy(FakeConfig, 'get');
fakeConfigUpdateSpy = sinon.spy(FakeConfig, 'update');
Expand Down
1 change: 0 additions & 1 deletion test/integration/runConfigs/testConfigsJava.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ describe('test configs in a Java Project', () => {

beforeEach(async () => {
sinon = createSandbox();
sinon.stub(os, 'homedir').returns(ProjectJava);

fakeConfigGetSpy = sinon.spy(fakeConfig, 'get');
fakeConfigUpdateSpy = sinon.spy(fakeConfig, 'update');
Expand Down

0 comments on commit c44c7b9

Please sign in to comment.