Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the VS Code marketplace extension readme. #1028

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

petecheslock
Copy link
Contributor

@kgilpin called out missing commands which I added.

Do we want to update the examples? We've got an end to end Navie video now - do we want to embed or link to this video?
https://vimeo.com/1012769182

Copy link
Contributor

@Daniel-Warner-X Daniel-Warner-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petecheslock I think you can remove the numbered list of links to specific examples and update the text in the 'Examples' section to make 'Here are some examples...' a link that goes to https://appmap.io/product/examples/navie.

Also, I think you can remove 'By using AppMap data...' on line 14 and start that paragraph at Navie is the first.... That initial clause makes the sentence hard to parse.

@petecheslock petecheslock changed the title Update the VS Code marketplace extension readme. fix: Update the VS Code marketplace extension readme. Oct 2, 2024
@dustinbyrne dustinbyrne self-requested a review October 4, 2024 14:12
@dustinbyrne dustinbyrne merged commit 6a70b39 into develop Oct 4, 2024
3 of 4 checks passed
@dustinbyrne dustinbyrne deleted the feat/update-readme branch October 4, 2024 14:25
@appland-release
Copy link
Contributor

🎉 This PR is included in version 0.130.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants