fix: Write an OpenAI-compatible error when context overflows #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apotterri
suggested changes
Oct 4, 2024
| const response = await postAuthorized(chatCompletion.url, { | ||
| model: 'test-model', | ||
| messages, | ||
| stream: true, |
There was a problem hiding this comment.
stream shouldn't be here, should it? The example says, "when not streaming".
| { content: 'How are you?', role: 'assistant' }, | ||
| { content: 'I am good, thank you!', role: 'user' }, | ||
| ]; | ||
| const response = await postAuthorized(chatCompletion.url, { model: 'test-model', messages }); |
There was a problem hiding this comment.
And this one seems like it needs stream: true?
There was a problem hiding this comment.
Yeah, it looks like I had named the test cases backwards. This is fixed now 👍
dustinbyrne
force-pushed
the
fix/context-length-error
branch
from
2ab7a44
to
2bc68bb
Compare
apotterri
approved these changes
Oct 4, 2024
dividedmind
approved these changes
Oct 6, 2024
|
🎉 This PR is included in version 0.130.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the server would report an error stating
Message exceeds token limit..This error is now transformed into an OpenAI API compatible error, mimicking the same error returned by the official OpenAI API. This change allows Navie to properly reduce the token count before trying again.