Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Broaden install prompt #705

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

kgilpin
Copy link
Contributor

@kgilpin kgilpin commented Jun 5, 2023

Prompt to install if a project satisfies all of:

  • Has a supported language
  • Has a supported framework
  • Does not already have an appmap.yml

@dividedmind FYI

Prompt to install if a project satisfies all of:
* Has a supported language
* Has a supported framework
* Does not already have an appmap.yml
@kgilpin kgilpin force-pushed the feat/broaden-install-prompt branch from 689c254 to 03cb39a Compare June 5, 2023 17:36
Base automatically changed from fix/prefer-web-framework-language to master June 6, 2023 15:44
@dividedmind
Copy link
Contributor

Looks ok to me. BTW, you should probably pull #698 lest someone else will start doing it, too.

@kgilpin
Copy link
Contributor Author

kgilpin commented Jun 8, 2023

@dustinbyrne let's check the telemetry data 7 days from now (June 15) and see if we should enable this for Python.

@dustinbyrne dustinbyrne changed the base branch from master to develop September 1, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants