Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select finding when opening map #791

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

ahtrotta
Copy link
Contributor

@ahtrotta ahtrotta commented Aug 31, 2023

Fixes #789

Previously, when opening an AppMap from the findings webview:

image

It would open to the Trace View:

image

This change makes it so that it opens the AppMap to the finding:

image

@dustinbyrne dustinbyrne changed the base branch from master to develop September 1, 2023 18:09
@ahtrotta ahtrotta force-pushed the feat/select-finding-when-opening-map branch from 1cb8db8 to b072f96 Compare September 1, 2023 20:32
@ahtrotta ahtrotta marked this pull request as ready for review September 5, 2023 18:18
@dustinbyrne dustinbyrne self-requested a review September 5, 2023 18:53
@dustinbyrne dustinbyrne merged commit 738ac35 into develop Sep 5, 2023
2 checks passed
@dustinbyrne dustinbyrne deleted the feat/select-finding-when-opening-map branch September 5, 2023 18:54
@appland-release
Copy link
Contributor

🎉 This PR is included in version 0.101.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Findings should open to the correct view
3 participants