Consistent delete behavior from command palette #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahtrotta
suggested changes
Sep 22, 2023
There was a problem hiding this comment.
This isn't working consistently for me (I'm on Linux, specifically Debian). To reproduce:
- Make a fresh clone of
spring-petclinicin a fresh directory with a unique path that has never been used (VS Code will cache certain information about your project if you use the same project path). - Make sure you have the Extension Pack for Java installed in VS Code.
- When it asks you to use Maven or Gradle, select Maven:
- Open the Test Runner and run the system tests:
- You should see these AppMaps:
- Run
Delete All AppMapsfrom the Command Pallette:
- The AppMaps do not disappear from the AppMaps tree view even though they are removed from the filesystem:
moxw
force-pushed
the
fix/consistent-delete-behavior
branch
from
08d569d to
0466e11
Compare
…appmaps feat(contextMenu.ts): update deleteAppMap command to handle absence of item object feat(deleteAppMap.test.ts): add new integration test for deleteAppMap fix(closeEditorByUri.test.ts): fix test to include input conditions feat(deleteAppMaps.ts): add clear method to AppMapCollection after closing editors feat(appmapCollection.ts): introduce clear method in AppMapCollection interface feat(appmapCollectionFile.ts): implement clear method for AppMapCollectionFile class
moxw
force-pushed
the
fix/consistent-delete-behavior
branch
from
0466e11 to
98649f9
Compare
I wasn't able to reproduce this exactly step-by-step (the tests didn't complete explore appmaps) but I could see this happening in some other scenarios. So, I have added a clear method to clear the tree when deleteAllAppMaps is called. This should take care of all the scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #799
feat(deleteAppMaps.ts): add closeEditorByUri function after deleting appmaps
feat(contextMenu.ts): update deleteAppMap command to handle absence of item object
feat(deleteAppMap.test.ts): add new integration test for deleteAppMap
fix(closeEditorByUri.test.ts): fix test to include input conditions