feat: Search + Explain with Navie #845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilpin
force-pushed
the
feat/search-appmaps
branch
2 times, most recently
from
1b459e3
to
6985899
Compare
kgilpin
force-pushed
the
feat/search-appmaps
branch
from
2b62cec
to
f178f84
Compare
kgilpin
force-pushed
the
feat/search-appmaps
branch
from
f178f84
to
af2db3f
Compare
kgilpin
commented
Dec 21, 2023
| @@ -28,12 +29,6 @@ export default function getWebviewContent( | |||
| <head> | |||
| <meta charset="UTF-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <meta http-equiv="Content-Security-Policy" content=" | |||
There was a problem hiding this comment.
@dividedmind as our resident security person, and I think you added this initially, why was this added? We need to allow the UI to invoke JSON-RPC to our services.
There was a problem hiding this comment.
This is to prevent the webview content from being coerced to load external resources, which could cause data leak or worse. I don't think it's a good idea to remove this altogether; instead a directive like connect-src http://localhost:12345; should be added. Although ideally I think the UI shouldn't talk to the services directly at all; instead the extension should intermediate.
kgilpin
force-pushed
the
feat/search-appmaps
branch
4 times, most recently
from
62c0170
to
a0a7631
Compare
On code selection, provide a 'Search AppMaps' "Code Action" aka lightbulb action. Normalize the user's text selection and make an RPC to the AppMap search provider. Display the search results in VSCode.
Use webview
kgilpin
force-pushed
the
feat/search-appmaps
branch
from
06f20d6
to
084fcab
Compare
|
See #859 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.