Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop specific vs code version number for testing #850

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions test/integrationTest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ async function integrationTest() {
const extensionDevelopmentPath = resolve(__dirname, '..');
const userDataDir = resolve(__dirname, '../.vscode-test/user-data');

const vscodeExecutablePath = await downloadAndUnzipVSCode('1.81.1');
const vscodeExecutablePath = await downloadAndUnzipVSCode();
const [cliPath] = resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath);

if (process.env.TEST_YARN_INSTALL !== 'false') {
Expand All @@ -106,23 +106,10 @@ async function integrationTest() {
);
}

cp.spawnSync(
cliPath,
[
'--extensions-dir',
extensionDevelopmentPath,
'--user-data-dir',
userDataDir,
'--install-extension',
'appland.appmap',
'--force',
'--password-store=basic',
],
{
encoding: 'utf-8',
stdio: 'inherit',
}
);
cp.spawnSync(cliPath, ['--user-data-dir', userDataDir, '--force', '--password-store=basic'], {
encoding: 'utf-8',
stdio: 'inherit',
});

const runTests = async (testFile: string, workspaceDir: string) => {
startTime = new Date();
Expand Down
1 change: 0 additions & 1 deletion test/system/src/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ interface LaunchOptions {

export async function downloadCode(): Promise<string> {
return await downloadAndUnzipVSCode({
version: '1.81.1',
reporter: new ConsoleReporter(false),
});
}
Expand Down
Loading