Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate the chat search frontend #855

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

dustinbyrne
Copy link
Contributor

This is necessary to make authenticated HTTP requests, such as providing message feedback.

@kgilpin
Copy link
Contributor

kgilpin commented Jan 2, 2024

What’s message feedback?

Can we or should we do this through the RPC layer instead? That is more reusable with JetBrains.

@dustinbyrne
Copy link
Contributor Author

It's just a standard API call via browser fetch so it should also work in Jetbrain's JCEF. For that reason I don't know that it's necessarily worth routing it through RPC call.

@kgilpin
Copy link
Contributor

kgilpin commented Jan 2, 2024

Can you explain what the feature is that this is supporting?

@dustinbyrne
Copy link
Contributor Author

This is used by the feedback buttons

Peek.2024-01-02.14-43.webm

@kgilpin kgilpin added the enhancement New feature or request label Jan 5, 2024
@dustinbyrne dustinbyrne merged commit 06f20d6 into feat/search-appmaps Jan 5, 2024
0 of 2 checks passed
@dustinbyrne dustinbyrne deleted the fix/search-feedback branch January 5, 2024 18:15
@dustinbyrne dustinbyrne restored the fix/search-feedback branch January 16, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants