Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include directory when parsing context location #954

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

dustinbyrne
Copy link
Contributor

@dustinbyrne dustinbyrne commented Apr 29, 2024

@dustinbyrne dustinbyrne requested a review from ahtrotta April 29, 2024 14:09
@ahtrotta
Copy link
Contributor

I re-ran the integration tests and a different one failed, so it seems like they're suddenly unstable again. Both failing tests had to do with expecting tree providers to have the expected tree items.

@kgilpin
Copy link
Contributor

kgilpin commented Apr 29, 2024

I re-ran the integration tests and a different one failed, so it seems like they're suddenly unstable again. Both failing tests had to do with expecting tree providers to have the expected tree items.

FYI tree provider has a known bug - #930

Copy link
Contributor

@ahtrotta ahtrotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and worked well when I tested it manually in a workspace with multiple project folders 👍

@dustinbyrne dustinbyrne force-pushed the feat/update-open-location branch from 8259243 to 914d42d Compare April 29, 2024 19:13
@dustinbyrne dustinbyrne marked this pull request as ready for review April 29, 2024 19:13
@dustinbyrne dustinbyrne merged commit 442c94e into develop Apr 29, 2024
1 check passed
@dustinbyrne dustinbyrne deleted the feat/update-open-location branch April 29, 2024 19:13
@appland-release
Copy link
Contributor

🎉 This PR is included in version 0.118.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants