Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort alphabetically #76

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ignacio-chiazzo
Copy link

This PR alphabetically sorts the docs.jsonl (it was getting too large).

Changes made:

  1. Sorted the docs.jsonl file.
  2. Added a function to sort the files alphabetically (tests/sort_docs.js).
  3. Added a test file that checks whether the files are sorted (tests/test_docs_sort.js).

Demo

1—To check that both contents are equal, I copied the old docs.jsonl and the new one, added them to an array, and compared the sorted value. In the image below, sorted is the new array, and not_sorted is the old.

Screenshot 2025-01-15 at 10 07 59 AM

2- You can run the tests node tests/test_docs_sort.js

Next steps

This should be part of the CI integrations. If you agree, I can add a yml file using Github Actions.

Screen.Recording.2025-01-15.at.10.18.45.AM.mov

@ignacio-chiazzo
Copy link
Author

cc @truell20 can I get a review? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant