Fix taxonomy label URL #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: In blog item page, the taxonomy labels always point to the `blog.url`. It does not work well with a website with multiple blog-type pages. Different blogs can have their own blog root. A taxonomy at `/blog1/item1` should point to `/blog1`, and `/blog2/item1` should point to `/blog2` respectively. Fix: Always point the taxonomy URL to the parent page.
|
Unfortunately this only works for pages that are direct children of the blog. There are many situations where there are multiple levels of nested pages under the blog listing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In a blog item page, the taxonomy labels always point to the
blog.url. It does not work well with a website with multiple blog-type pages. Different blogs can have their own blog root. A taxonomy at/blog1/item1should point to/blog1, and/blog2/item1should point to/blog2respectively.Fix:
Always point the taxonomy URL to the parent page.