Two phase dialer implementation that first connects as quickly as possible #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed at reducing the time it takes a user to get connected at startup while also improving reliability.
The current bandit implementation connects quickly but also experiments with dialers that may not connect at all, thereby hurting the user experience.
This PR switches to a two-phase dialer. In the first phase, we simply try to connect as quickly as possible to all available dialers. If dialers can't connect at all, we discard them. Any dialer that connect at all is immediately available to callers. Then, when we've tested all the dialers for connectivity, we send the connecting dialers and switch to the multi-armed bandit dialer that optimizes for the best dialer to use.