Store Flow Changes (Support for restore flow) #1113

jigar-f · 2024-07-01T06:25:00Z

No description provided.

jigar-f · 2024-07-01T11:53:49Z

Got the issue on IOS about the app tracking policy working on that

atavism · 2024-09-03T21:08:30Z

lib/common/app_methods.dart

@@ -36,14 +36,34 @@ class AppMethods {
  }

  static Future<bool> isPlayStoreEnable() async {
-    if(!Platform.isAndroid){
+    if (!Platform.isAndroid) {
      return false;
    }
    final isPlayVersion = sessionModel.isStoreVersion.value ?? false;


I tried testing these changes on Android by setting FORCE_PLAY_VERSION=true, and It looks like isPlayVersion always returns false. Are we setting storeVersion on the session model to BuildConfig.PLAY_VERSION?

For me, it is working, Could you confirm that your is not a pro?

atavism · 2024-09-03T21:58:07Z

I did some testing (by manually setting isPlayVersion to true), and one issue that I encountered is on the restore purchase page, after I enter the email associated with my Pro user along with the subsequent confirmation code, I get an "email not verified" error:

09-03 14:42:21.029 29092 29170 E GoLog   : Sep 03 21:42:21.029 - 29m18s DEBUG defaultwebclient: response.go:66 response body: <error-email-not-verified> status code 500
09-03 14:42:21.030 29092 29191 I GoLog   : Sep 03 21:42:21.029 - 29m18s ERROR proclient: pro.go:371 <error-email-not-verified> status code 500 [error=%v error_location=github.com/getlantern/lantern-client/internalsdk/pro.(*proClient).RestorePurchase (pro.go:371) error_text=<error-email-not-verified> status code 500 error_type=errors.Error]
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at github.com/getlantern/lantern-client/internalsdk/pro.(*proClient).RestorePurchase (pro.go:371)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at github.com/getlantern/lantern-client/internalsdk.restorePurchase (session_model.go:1553)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at github.com/getlantern/lantern-client/internalsdk.(*SessionModel).doInvokeMethod (session_model.go:346)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at github.com/getlantern/lantern-client/internalsdk.(*baseModel).InvokeMethod (model.go:103)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at main.proxyinternalsdk_SessionModel_InvokeMethod (go_internalsdkmain.go:669)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at _cgoexp_7a18dc8f8e4b_proxyinternalsdk_SessionModel_InvokeMethod (_cgo_gotypes.go:2494)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at runtime.cgocallbackg1 (cgocall.go:420)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at runtime.cgocallbackg (cgocall.go:339)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at runtime.cgocallback (asm_arm64.s:1130)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at runtime.goexit (asm_arm64.s:1222)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371 Caused by: <error-email-not-verified> status code 500

This may be unrelated to this PR, but I wonder if the pro server may not be updating users to have verified email addresses after they enter a valid confirmation code (unless I'm getting that error for some other reason?).

jigar-f · 2024-09-04T09:43:43Z

I did some testing (by manually setting isPlayVersion to true), and one issue that I encountered is on the restore purchase page, after I enter the email associated with my Pro user along with the subsequent confirmation code, I get an "email not verified" error:

09-03 14:42:21.029 29092 29170 E GoLog   : Sep 03 21:42:21.029 - 29m18s DEBUG defaultwebclient: response.go:66 response body: <error-email-not-verified> status code 500
09-03 14:42:21.030 29092 29191 I GoLog   : Sep 03 21:42:21.029 - 29m18s ERROR proclient: pro.go:371 <error-email-not-verified> status code 500 [error=%v error_location=github.com/getlantern/lantern-client/internalsdk/pro.(*proClient).RestorePurchase (pro.go:371) error_text=<error-email-not-verified> status code 500 error_type=errors.Error]
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at github.com/getlantern/lantern-client/internalsdk/pro.(*proClient).RestorePurchase (pro.go:371)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at github.com/getlantern/lantern-client/internalsdk.restorePurchase (session_model.go:1553)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at github.com/getlantern/lantern-client/internalsdk.(*SessionModel).doInvokeMethod (session_model.go:346)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at github.com/getlantern/lantern-client/internalsdk.(*baseModel).InvokeMethod (model.go:103)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at main.proxyinternalsdk_SessionModel_InvokeMethod (go_internalsdkmain.go:669)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at _cgoexp_7a18dc8f8e4b_proxyinternalsdk_SessionModel_InvokeMethod (_cgo_gotypes.go:2494)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at runtime.cgocallbackg1 (cgocall.go:420)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at runtime.cgocallbackg (cgocall.go:339)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at runtime.cgocallback (asm_arm64.s:1130)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371   at runtime.goexit (asm_arm64.s:1222)
09-03 14:42:21.030 29092 29191 I GoLog   : ERROR proclient: pro.go:371 Caused by: <error-email-not-verified> status code 500

This may be unrelated to this PR, but I wonder if the pro server may not be updating users to have verified email addresses after they enter a valid confirmation code (unless I'm getting that error for some other reason?).

This is correct, You get this error only when you enter an expired code while verification. Can you try again and see if that's an issue, it should work.

jigar-f · 2024-09-13T06:40:23Z

@atavism Could you review this?

jigar-f · 2024-09-16T11:40:01Z

@atavism Could you please give this PR spin? I like to merge this if all okay

jigar-f added 2 commits June 26, 2024 21:51

Increase internet check timeout to 5 sec

0e7b75c

Uploaded 8.0.0 testflight.

3961067

jigar-f marked this pull request as ready for review July 1, 2024 06:25

jigar-f self-assigned this Jul 1, 2024

jigar-f added the WIP label Jul 1, 2024

jigar-f added 5 commits July 1, 2024 19:24

Merge branch 'main' into jigar/ios-upload-8.0

24df13a

Removed NSUserTrackingUsageDescription permission..

b085ba4

Uploaded 8.0.0 (40) to testflight.

1a97b34

updated plans page UI for ios.

cda94fd

Uploaded new build to testflight.

b1319ec

jigar-f changed the title ~~Uploaded IOS 8.0.0 to TestFlight.~~ IOS 8.0.0 App Store Changes Jul 10, 2024

jigar-f added 18 commits July 31, 2024 14:42

Merge branch 'main' into jigar/ios-upload-8.0

264a06f

UI changes.

5f5efcd

Merge branch 'main' into jigar/ios-upload-8.0

43685dd

UI changes for new flow.

17ddfc5

UI changes for restore flow.

73a3bb0

restore purchase for android.

dc5fccc

Merge branch 'main' into jigar/ios-upload-8.0

5200ac7

New screen for restore purchase verification.

9ea184d

More changes related to restore flow.

ff2f004

Uploaded build to testflight.

40cb115

Design new email screen.

3c12ffe

Update restore purchase flow.

023a805

Update restore_purchase_verification.dart

3f334cc

update UI.

be732de

new restore flow changes.

66ad487

Update restore purchase request.

7f7bd8d

Remove direct flow.

cb3b509

Updated error message.

1721f61

jigar-f added 4 commits September 2, 2024 22:53

Uploaded 8.0.2 to testflight.

0f886ce

Merge branch 'main' into jigar/ios-upload-8.0

2f22868

Fixed merged conflicts.

b4c31ab

More changes for dekstop.

c055ecd

atavism reviewed Sep 3, 2024

View reviewed changes

Fixed UI not updating on logout.

a088b67

jigar-f added 13 commits September 4, 2024 18:04

Added some changes for android flow

b019a4d

update http client.

050dbcc

Fixed checkout issue.

7241201

More small fixed on desktop

063637a

invalidate cache on plans cache.

a380126

Merge branch 'main' into jigar/ios-upload-8.0

2ec7190

Fixed merge conflicts.

d0b1330

added CreateBinaryFile utils method.

4bec68e

Merge branch 'main' into jigar/ios-upload-8.0

2a1bc60

Fixed merge conflicts.

0f720fa

Change UI branch.

2878d99

Revert back CI branch.

09be08d

Merge branch 'main' into jigar/ios-upload-8.0

f60f981

jigar-f removed the on hold label Sep 13, 2024

jigar-f added 2 commits September 13, 2024 13:08

Change some wording and fix webview issue.

2fdb875

Fixed issue when user is pro and device is not added.

26ba454

jigar-f added 2 commits September 16, 2024 17:59

use auth flag.

20c105b

Remove unused methods.

f7a1cb9

jigar-f merged commit 9d91f1c into main Sep 17, 2024
2 checks passed

jigar-f deleted the jigar/ios-upload-8.0 branch September 17, 2024 06:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Store Flow Changes (Support for restore flow) #1113

Store Flow Changes (Support for restore flow) #1113

jigar-f commented Jul 1, 2024

jigar-f commented Jul 1, 2024

atavism Sep 3, 2024 •

edited

Loading

jigar-f Sep 4, 2024

atavism commented Sep 3, 2024

jigar-f commented Sep 4, 2024

jigar-f commented Sep 13, 2024

jigar-f commented Sep 16, 2024

Store Flow Changes (Support for restore flow) #1113

Store Flow Changes (Support for restore flow) #1113

Conversation

jigar-f commented Jul 1, 2024

jigar-f commented Jul 1, 2024

atavism Sep 3, 2024 • edited Loading

Choose a reason for hiding this comment

jigar-f Sep 4, 2024

Choose a reason for hiding this comment

atavism commented Sep 3, 2024

jigar-f commented Sep 4, 2024

jigar-f commented Sep 13, 2024

jigar-f commented Sep 16, 2024

atavism Sep 3, 2024 •

edited

Loading